Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE msvc .res build #377

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Fix NPE msvc .res build #377

merged 2 commits into from
Jul 23, 2021

Conversation

GregDomjan
Copy link
Member

The commands list was not initialized for resource compilation.
Not clear on any need to do so, chosen to simply check for null and skip step of adding command

@GregDomjan
Add stack trace for generic exception in build threads
9d0acfc
@GregDomjan
Fix NPE for building resource
1856ac3 
dryRun command tracking not initialized
unclear on assumption of commands being initialized
@GregDomjan GregDomjan merged commit 818e081 into master Jul 23, 2021
@GregDomjan GregDomjan deleted the feature/fix-NPE-res-build branch July 23, 2021 08:57
@GregDomjan
Copy link
Member Author

Resolved #370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GregDomjan